Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make EthStorage generic over transaction #13549

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 24, 2024

We can use same logic as long it's same reth_primitives::Block with different transactions

Allows to directly reuse EthStorage for OP

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #13549 will degrade performances by 10.62%

Comparing klkvr/generic-eth-storage (a1ffd72) with main (c6e38be)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 74 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/generic-eth-storage Change
`prefix set size: 10 BTreeSet with BTreeSet:range lookup` 6.3 µs
`hash builder[init size 1000 update size 100 num updates 1]` 2.4 ms
`receipts root size: 10 HashBuilder` 120.3 µs

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, these indeed operate on the same types so we can reuse.

very nice

@mattsse mattsse added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit edd2511 Dec 25, 2024
42 of 43 checks passed
@mattsse mattsse deleted the klkvr/generic-eth-storage branch December 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants