added helper error enums for L1BlockInfoError #14326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoulavBhowmick03
requested review from
mattsse,
Rjected and
fgimenez
as code owners
PoulavBhowmick03
force-pushed
the
helper_error_l1block
branch
from
228f943 to
91b2ab5
Compare
emhane
added
C-debt
emhane
requested changes
Feb 8, 2025
There was a problem hiding this comment.
very nice!
one comment, variant for BaseFeeScalarConversion is missing. l1_fee_scalar and l1_base_fee_scalar are essentially different values. see the nice docs here:
https://github.com/alloy-rs/op-alloy/blob/d1f9aa5b8111286b5340aa793315b6895e05b258/crates/rpc-types/src/receipt.rs#L136-L190
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14274
crates/optimism/evm/src/error.rsto add helper error enums and modifiedL1BlockInfoto pass in theL1BlockInfoErrorenumcrates/optimism/evm/src/l1.rsto implement this change and use the new helper error enumsPS-
crates/net/network/src/peers.rsandcrates/net/network/src/test_utils/testnet.rs, since it popped up while runningmake pr