Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Correct functionality of get_queued_transactions_by_sender and get_pending_transactions_by_sender #14353

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix: Correct functionality of get_queued_transactions_by_sender and get_pending_transactions_by_sender #14353

merged 1 commit into from
Feb 10, 2025

Conversation

0xNarumi
Copy link
Contributor

Simple functionality fix: pending was reading from the queued pool, and vice versa.

@0xNarumi 0xNarumi requested a review from mattsse as a code owner February 10, 2025 09:24
@0xNarumi 0xNarumi changed the title Fix: Correct functionality of get_queued_transactions_by_sender and get_pending_transactions_by_sender Fix: Correct functionality of get_queued_transactions_by_sender and get_pending_transactions_by_sender Feb 10, 2025
mattsse
mattsse approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie

ty

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-tx-pool Related to the transaction mempool labels Feb 10, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #14353 will improve performances by 10.07%

Comparing risechain:fix (8629895) with main (f84d497)

Summary

⚡ 1 improvements
✅ 76 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ hash builder[init size 10000 | update size 100 | num updates 3] 28.9 ms 26.2 ms +10.07%

@mattsse mattsse added this pull request to the merge queue Feb 10, 2025
Merged via the queue into paradigmxyz:main with commit 6172872 Feb 10, 2025
45 checks passed
@hai-rise hai-rise deleted the fix branch February 11, 2025 06:45
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@0xNarumi @18aaddy
Fix: Correct functionality of get_queued_transactions_by_sender and…
2d92f7c 
… `get_pending_transactions_by_sender` (paradigmxyz#14353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNarumi @mattsse