feat: EngineApiBuilder
#14354
Merged
feat: EngineApiBuilder
#14354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez and
onbjerg
as code owners
emhane
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
lgtm. makes sense imo to double this up in op-alloy and just change result type to RpcResult to derive jsonrpsee to close #14211
Comment on lines
+663
to
+665
| pub struct BasicEngineApiBuilder<EV> { | ||
| engine_validator_builder: EV, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub struct BasicEngineApiBuilder<EV> { | |
| engine_validator_builder: EV, | |
| } | |
| pub struct BasicEngineApiBuilder<EB> { | |
| engine_api_builder: EB, | |
| } |
There was a problem hiding this comment.
this is an engine_validator_builder as it provides EngineValidator to pass here
There was a problem hiding this comment.
hm then can the struct name change to BasicEngineValidatorBuilder ?
There was a problem hiding this comment.
ah I see this pr also aggregates the validator api and the regular api into one type. docs could be more helpful in reflecting this design choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #13831
Add
EngineApiBuildertoRpcAddOnswhich uses defaultEngineApiimpl by default but already can be customized to use any implementation.Technically this is all we need for #13831 but I think we can keep it open until we have at least one usecase for custom engine API implemented (either OP or custom header example)