feat: add Consensus to ExecutionStage
#14447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
onbjerg,
rkrasiuk,
shekhirin,
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Feb 12, 2025
Comment on lines
+204
to
+213
| pub trait CliNodeComponents<N: CliNodeTypes> { | ||
| /// Block executor. | ||
| type Executor: BlockExecutorProvider<Primitives = N::Primitives>; | ||
| /// Consensus implementation. | ||
| type Consensus: FullConsensus<N::Primitives, Error = ConsensusError> + Clone + 'static; | ||
|
|
||
| /// Returns the block executor. | ||
| fn executor(&self) -> &Self::Executor; | ||
| /// Returns the consensus implementation. | ||
| fn consensus(&self) -> &Self::Consensus; |
There was a problem hiding this comment.
this makes sense, this is likely something we need to integrate in cli trait somehow
cc @fgimenez for vis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decouple execution and validation we need to keep separate
Consenusinstance onExecutionStageThis also refactors CLI a bit and introduces helper
CliNodeComponentstrait which can be easily extended later to give access to more chain-specific components to cli commands