-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dumpgenesis subcommand #6797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like this to be named dump-genesis or similar, and i would also like for the book to be updated: https://paradigmxyz.github.io/reth/cli/reth.html
i would also like a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbnerZheng let's just keep the chain Arc Chainspec field and remove the others.
I think this is fine, and mirrors the behaviour of other subcommand. having geth compatibility here isn't that important.
so please remove all bool flags and just keep the chain field
and please add a parser test, see other subcommand for examples
I have made the change, PTAL again. |
Updated help message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Close #5833
If no Dumpgenesis argument(like
--mainnet
) is provided, we simply use the chain argument.