Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana/overview: add RPC QPS dashboard #7025

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 7, 2024

Added a new dashboard to represent the RPC QPS

image

@jsvisa jsvisa requested a review from gakonst as a code owner March 7, 2024 04:11
@jsvisa
Copy link
Contributor Author

jsvisa commented Mar 8, 2024

@emhane PTAL thanks:)

@emhane
Copy link
Member

emhane commented Mar 8, 2024

nice! since you have to fix merge conflicts anyway, can you please change base to emhane/tx-pool-grafana. fixing merge conflicts with this file on every pr is a headache. at best you follow the pattern we started for tx pool and move all rpc panels to their own dashboard 'reth-rpc', but up to you. can be a new pr in that case, since it's out of scope here.

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Mar 8, 2024
jsvisa added 4 commits March 9, 2024 14:44
Signed-off-by: jsvisa <[email protected]>
This reverts commit d560aad.

Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
@jsvisa jsvisa force-pushed the grafana-rpc-qps branch from 427a0e9 to 24d2690 Compare March 9, 2024 06:47
@emhane emhane enabled auto-merge March 9, 2024 18:29
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot this is great

@emhane emhane added this pull request to the merge queue Mar 9, 2024
Merged via the queue into paradigmxyz:main with commit a8345e3 Mar 9, 2024
27 checks passed
@jsvisa jsvisa deleted the grafana-rpc-qps branch March 9, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants