perf(tree): integrate parallel state root #7161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-perf
|
Performance Improvements on tip
|
rkrasiuk
requested review from
rakita,
joshieDo,
shekhirin and
gakonst
as code owners
gakonst
approved these changes
Mar 16, 2024
Comment on lines
+214
to
+220
| let mut state = provider.bundle_state_data_provider.state().clone(); | ||
| state.extend(bundle_state.clone()); | ||
| let hashed_state = state.hash_state_slow(); | ||
| ParallelStateRoot::new(consistent_view, hashed_state) | ||
| .incremental_root_with_updates() | ||
| .map(|(root, updates)| (root, Some(updates))) | ||
| .map_err(ProviderError::from)? |
onbjerg
approved these changes
Mar 20, 2024
Comment on lines
12
to
16
| /// NOTE: It is recommended to provide a different implementation from | ||
| /// `state_root_with_updates` since it affects the memory usage during state root | ||
| /// computation. |
There was a problem hiding this comment.
smol doc nit
Suggested change
| /// NOTE: It is recommended to provide a different implementation from | |
| /// `state_root_with_updates` since it affects the memory usage during state root | |
| /// computation. | |
| /// # Note | |
| /// | |
| /// It is recommended to provide a different implementation from | |
| /// `state_root_with_updates` since it affects the memory usage during state root | |
| /// computation. |
mattsse
approved these changes
Mar 20, 2024
|
@rkrasiuk some conflicts left |
rkrasiuk
force-pushed
the
rkrasiuk/tree-integrate-parallel-state-root
branch
from
ffde69e to
81259bd
Compare
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate parallel state root computation (pre-computing storage roots in parallel) introduced in #6903 into the blockchain tree.