Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove txpool optimism feature #7199

Merged
merged 3 commits into from
Mar 18, 2024
Merged

chore: remove txpool optimism feature #7199

merged 3 commits into from
Mar 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 18, 2024

This is no longer required

optimism txs aren't allowed into the pool.

this however requires unreachable_patterns

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Mar 18, 2024
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, at some point later we may want to create a new type for tx types in context of tx pool to allow for exhaustive matches

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 18, 2024

yeah this should be part of a new Transaction trait we need to integrate eventually

@mattsse mattsse added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit de9fb89 Mar 18, 2024
27 checks passed
@mattsse mattsse deleted the matt/rm-txpool-optimism branch March 18, 2024 19:53
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants