fix: configure global rayon pool to available_parallelism() - 2
#7267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-bug
mattsse
requested changes
Mar 21, 2024
crates/node-builder/src/builder.rs
Outdated
Comment on lines
445
to
449
| ThreadPoolBuilder::new() | ||
| .num_threads( | ||
| available_parallelism().map_or(25, |cpus| max(cpus.get().saturating_sub(2), 2)), | ||
| ) | ||
| .build_global()?; |
There was a problem hiding this comment.
can we ignore the error here and log it instead?
in case the user already configured this
mattsse
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
lgtm, pending @rkrasiuk
this should not have any effect on state root related tasks but is a simple solution for #6888
I think another solution we should explore is not using for any io at all in the sender recovery stage when in rayon context, but this needs more benchmarking effort, so this should be a quick fix for #6888 and any other stage that utilizes rayon for a long time
rkrasiuk
approved these changes
Mar 21, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures the global rayon pool to
available_parallelism() - 2, making sure we don't starve other jobs when doing heavy prolongued workref #6888