fix: return an error if block does nit exist #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-bug
Rjected
approved these changes
Mar 28, 2024
Comment on lines
+549
to
+551
| let resp = client.request::<Vec<Log>, _>("eth_getLogs", params).await; | ||
| // block does not exist | ||
| assert!(resp.is_err()); |
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7371
previously we returned an empty list for a ethGetLogs request with a hash if we were unable to find that block.
This is incorrect behaviour because this indicates that there are no matches for the filter.
this returns an error instead