Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tx-mgr): report peers that send known bad transactions #7400

Merged
merged 7 commits into from
Mar 31, 2024
Merged

fix(tx-mgr): report peers that send known bad transactions #7400

merged 7 commits into from
Mar 31, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Mar 30, 2024 •
edited
Loading

  • Bug fix, down score peers that send transactions that are cached in bad_imports
  • Removes confusing call to on_good_import on bad import.
  • Moves all bad import logic (bad and not bad transaction errors) into function
  • Fix use of bad_imports metric, to reflect imports that fail due to bad transaction, rather than number of times a bad transaction is received (this is already more or less reported_bad_transactions metric).

@emhane emhane added C-bug An unexpected or incorrect behavior C-debt A clean up/refactor of existing code A-networking Related to networking in general labels Mar 30, 2024
@emhane emhane requested review from mattsse and Rjected as code owners March 30, 2024 14:47
mattsse
mattsse approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is a lot cleaner

optional suggestion re docs

@emhane emhane added this pull request to the merge queue Mar 31, 2024
Merged via the queue into main with commit 0c363ea Mar 31, 2024
27 checks passed
@emhane emhane deleted the emhane/bad-imports branch March 31, 2024 13:03
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@emhane @Ruteri
fix(tx-mgr): report peers that send known bad transactions (paradigmx…
29cc7e6 
…yz#7400)
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@emhane @Ruteri
fix(tx-mgr): report peers that send known bad transactions (paradigmx…
1d41284 
…yz#7400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse