Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node-core): unify stage progress log style #7426

Merged
merged 1 commit into from
Apr 2, 2024
Merged

chore(node-core): unify stage progress log style #7426

merged 1 commit into from
Apr 2, 2024

Conversation

shekhirin
Copy link
Collaborator

Make the pipeline stage log messages consistent with each other

Before

2024-04-02T15:01:52.308117Z  INFO Preparing stage pipeline_stages=12/12 stage=Finish checkpoint=1239230 target=1266825
2024-04-02T15:01:52.308136Z  INFO Executing stage pipeline_stages=12/12 stage=Finish checkpoint=1239230 target=1266825
2024-04-02T15:01:52.308347Z  INFO Stage finished executing pipeline_stages=12/12 stage=Finish checkpoint=1266825 target=1266825

After

2024-04-02T15:01:52.308117Z  INFO Preparing stage pipeline_stages=12/12 stage=Finish checkpoint=1239230 target=1266825
2024-04-02T15:01:52.308136Z  INFO Executing stage pipeline_stages=12/12 stage=Finish checkpoint=1239230 target=1266825
2024-04-02T15:01:52.308347Z  INFO Finished stage pipeline_stages=12/12 stage=Finish checkpoint=1266825 target=1266825

@shekhirin shekhirin added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools labels Apr 2, 2024
@shekhirin shekhirin requested review from onbjerg and mattsse April 2, 2024 15:12
@shekhirin shekhirin requested a review from gakonst as a code owner April 2, 2024 15:12
@shekhirin shekhirin enabled auto-merge April 2, 2024 15:13
@shekhirin shekhirin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 112c8a3 Apr 2, 2024
27 checks passed
@shekhirin shekhirin deleted the alexey/pipeline-stage-finished-log branch April 2, 2024 15:29
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@shekhirin @Ruteri
chore(node-core): unify stage progress log style (paradigmxyz#7426)
a15861a
Ruteri pushed a commit to Ruteri/reth that referenced this pull request Apr 17, 2024
@shekhirin @Ruteri
chore(node-core): unify stage progress log style (paradigmxyz#7426)
fc183bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse