Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exex): add Pool to ExExContext #7573

Merged
merged 20 commits into from
Apr 12, 2024
Merged

feat(exex): add Pool to ExExContext #7573

merged 20 commits into from
Apr 12, 2024

Conversation

shekhirin
Copy link
Collaborator

Needed for #7558

@shekhirin shekhirin added C-enhancement New feature or request A-exex Execution Extensions labels Apr 11, 2024
@shekhirin shekhirin requested a review from mattsse April 11, 2024 17:23
@shekhirin shekhirin marked this pull request as ready for review April 11, 2024 17:23
@shekhirin shekhirin force-pushed the alexey/exex-context-pool branch from 17f599a to d3ffa62 Compare April 12, 2024 07:41
mattsse
mattsse requested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be solved with the existing helper trait instead

reth/crates/node-builder/src/components/traits.rs

Line 11 in 9c5aea8

pub trait FullNodeComponents: FullNodeTypes + 'static {

@shekhirin shekhirin mentioned this pull request Apr 12, 2024
Merged
@shekhirin shekhirin changed the base branch from main to alexey/node-api-full-node-components April 12, 2024 14:44
Base automatically changed from alexey/node-api-full-node-components to main April 12, 2024 14:48
@shekhirin shekhirin enabled auto-merge April 12, 2024 16:25
@shekhirin shekhirin added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 2dcc012 Apr 12, 2024
27 checks passed
@shekhirin shekhirin deleted the alexey/exex-context-pool branch April 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane left review comments

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @mattsse @emhane