-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use async fns in minimal example #7600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we convert the other examples to use async fn
instead of impl Future
? This is much more readable
totally agree with dani, unless there's some non obvious advantage here. does this also mean we can do 2 exex's that are tokio::join'ed? |
I think if we want to convert it all to async fns, I'm going to scrap |
sgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bullish
ed50134
to
9779191
Compare
Converts the minimal example to showcases that an ExEx is just
async fn(ctx) -> future
and that you can useasync fn
s for both, allowing you to construct ExEx's without implementingFuture
manually