refactor: replace calculate_next_block_base_fee with alloy's builtin function
#7641
Conversation
crates/primitives/src/basefee.rs
Outdated
| ) | ||
| } | ||
| } | ||
| calc_next_block_base_fee(gas_used as u128, gas_limit as u128, base_fee as u128, base_fee_params) as u64 |
There was a problem hiding this comment.
i'd just re-export this and replace every call in the codebase with calc_next_block_base_fee, or alternatively import the alloy_eips crate where this is called
There was a problem hiding this comment.
I thought of doing that but felt that changing the function name throughout the whole codebase wouldn't be okay for me to do. If there is no issue with my approach can the PR be merged?
There was a problem hiding this comment.
re-export would be preferred here, even if this means we need to about a few type casts etc
There was a problem hiding this comment.
re-export would be preferred here, even if this means we need to about a few type casts etc
working on it
onbjerg
changed the title
calculate_next_block_base_fee with alloy's builtin functioncalculate_next_block_base_fee with alloy's builtin function
crates/primitives/src/basefee.rs
Outdated
| ) | ||
| } | ||
| } | ||
| calc_next_block_base_fee(gas_used as u128, gas_limit as u128, base_fee as u128, base_fee_params) as u64 |
There was a problem hiding this comment.
re-export would be preferred here, even if this means we need to about a few type casts etc
fixed in the latest commit |
Fixes #7635 by replacing
calculate_next_block_base_feefromreth/crates/primitives/src/basefee.rs
Line 26 in d4ea415