chore: move optimism bootnodes to reth-primitives
#7657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-networking
joshieDo
requested review from
emhane,
mattsse,
Rjected and
gakonst
as code owners
mattsse
approved these changes
Apr 15, 2024
crates/primitives/src/chain/spec.rs
Outdated
Comment on lines
919
to
926
| #[cfg(feature = "optimism")] | ||
| C::Base | C::Optimism => Some(op_nodes()), | ||
| #[cfg(feature = "optimism")] | ||
| C::BaseGoerli | | ||
| C::BaseSepolia | | ||
| C::OptimismGoerli | | ||
| C::OptimismSepolia | | ||
| C::OptimismKovan => Some(op_testnet_nodes()), |
There was a problem hiding this comment.
is this correct?
this uses the same nodes for multiple different chains?
There was a problem hiding this comment.
added the differentiation
mattsse
approved these changes
Apr 15, 2024
emhane
reviewed
Apr 16, 2024
Comment on lines
-135
to
-142
| if chain == Chain::optimism_mainnet() || chain == Chain::base_mainnet() { | ||
| builder = builder.add_optimism_mainnet_boot_nodes() | ||
| } else if chain == Chain::from_named(NamedChain::OptimismSepolia) || | ||
| chain == Chain::from_named(NamedChain::BaseSepolia) | ||
| { | ||
| builder = builder.add_optimism_sepolia_boot_nodes() | ||
| } | ||
|
|
There was a problem hiding this comment.
how are you adding the boot nodes now that this is removed?
There was a problem hiding this comment.
By adding the nodes to the ChainSpec, NetworkConfig will have them to serve to discovery_v5_with_config_builder
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title suggests.
Additionally it fixes an issue where op stack chains were loading ethereum mainnet boot nodes (in addition to op ones) because there were no bootnodes associated with their chain specs.