Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trie): simplify hashed cursor abstraction #8380

Merged
merged 3 commits into from
May 27, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented May 24, 2024

Description

Builds on top of #8377.

Refactor hashed cursors abstractions. Unify common methods to a single HashedCursor. Make HashedStorageCursor trait extend the HashedCursor trait.

@rkrasiuk rkrasiuk added the A-trie Related to Merkle Patricia Trie implementation label May 24, 2024
@rkrasiuk rkrasiuk requested review from mattsse and Rjected and removed request for mattsse May 24, 2024 16:29
Base automatically changed from rkrasiuk/account-specific-hashed-storage-cursor to main May 24, 2024 16:42
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few doc suggestions

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/refactor-hashed-cursor branch from 91ef237 to 93d2ae8 Compare May 27, 2024 12:26
@rkrasiuk rkrasiuk enabled auto-merge May 27, 2024 12:26
@rkrasiuk rkrasiuk added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit b4d7d36 May 27, 2024
30 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/refactor-hashed-cursor branch May 27, 2024 12:52
loocapro pushed a commit to loocapro/reth that referenced this pull request May 27, 2024
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants