Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move primitives/exex to reth-exex-types #8677

Merged
merged 2 commits into from
Jun 7, 2024
Merged

chore: move primitives/exex to reth-exex-types #8677

merged 2 commits into from
Jun 7, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jun 7, 2024

re: #8674

turns primitives/exex into its own crate

@joshieDo joshieDo added the C-debt A clean up/refactor of existing code label Jun 7, 2024
@joshieDo joshieDo changed the title chore: move primitives/prune to reth-prune-types chore: move primitives/exex to reth-exex-types Jun 7, 2024
mattsse
mattsse approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can potentially move more stuff there in case we run into circular deps issues

pending conflicts

@joshieDo joshieDo enabled auto-merge June 7, 2024 16:19
@joshieDo joshieDo added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit a7152ed Jun 7, 2024
30 checks passed
@joshieDo joshieDo deleted the joshie/exex-types branch June 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @onbjerg @mattsse