Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2503] Backport #7075 #7681

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link
Contributor

Backport #7075 into stable2503 from claravanstaden.

See the documentation on how to use this bot.

# Description

Adds support for the upcoming Ethereum Electra upgrade, while
maintaining backwards compatibility for the current Deneb fork.

## Integration

Relayers should be updated to send updated Electra consensus data
structures.

## Review Notes

The [Ethereum Electra hard-fork
consensus](https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/light-client/sync-protocol.md)
changes affecting the Ethereum light client are mainly isolated to the
[Generalized
Indexes](https://github.com/protolambda/eth2.0-ssz/blob/master/specs/navigation/generalized_indices.md)
of data structures changing. Before Electra, these values were hardcoded
in config. For Electra, these values change and needed to the updated.
Methods were added to return the correct g-index for the current fork
version.

Data structures used by the Ethereum client did not change in this
hard-fork. The BeaconState container has been updated with additional
changes, but because the on-chain code does not reference the
BeaconState directly (only indirectly through merkle proofs), it is not
a concern. Off-chain relayers use the BeaconState to generate proofs,
and so the relayer code has been updated accordingly.

### Companion PR for off-chain relayers
Snowfork/snowbridge#1283

---------

Co-authored-by: claravanstaden <Cats 4 life!>
Co-authored-by: Ron <[email protected]>
Co-authored-by: Vincent Geddes <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>
Co-authored-by: Vincent Geddes <[email protected]>
(cherry picked from commit dd7562a)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 24, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 24, 2025 08:55
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@claravanstaden
Copy link
Contributor

PR is ready to merge, checked the tests.

acatangiu
acatangiu previously approved these changes Feb 24, 2025
bkontur
bkontur previously approved these changes Feb 24, 2025
@acatangiu acatangiu dismissed stale reviews from bkontur and themself via 03f72fd February 24, 2025 12:21
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 24, 2025 12:23
@bkontur bkontur enabled auto-merge (squash) February 25, 2025 10:29
@EgorPopelyaev EgorPopelyaev merged commit f314047 into stable2503 Feb 25, 2025
248 of 260 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7075-to-stable2503 branch February 25, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants