-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9616
fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9616
Conversation
Thanks for opening this pull request! |
I guess you have seen it already - the CI fails for these tests:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9616 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 186 186
Lines 14816 14831 +15
=======================================
+ Hits 13856 13871 +15
Misses 960 960 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just to confirm, this is not a breaking change, right? For example, someone using Redis 3 can upgrade without any code changes.
I borrowed the code from RedisCacheAdapter. So we should be fine. |
# [8.0.0-alpha.12](8.0.0-alpha.11...8.0.0-alpha.12) (2025-02-24) ### Bug Fixes * LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9616](#9616)) ([bbc6bd4](bbc6bd4))
🎉 This change has been released in version 8.0.0-alpha.12 |
Pull Request
Issue
Closes: #9432
Approach
Add empty handlers to redis client error, connect, reconnecting, ready events.