FISH-10527 added nofollow to index page #7193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
reviewed
Feb 19, 2025
Pandrex247
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Confirmed, this isn't enough as-is.
We need to look at removing or overriding https://github.com/NotedSalmon/Payara/blob/FISH-10527-add-nofollow-to-index-page/nucleus/admin/template/pom.xml#L101-L108
This is an extremely old package which overrides essentially this entire module.
It appears to have always been here, something we inherited from GlassFish 3/4 ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added nofollow and tracking for links. Updated copyright year