Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DatabaseProvider.php #1451

Merged
merged 4 commits into from
Apr 18, 2020
Merged

Update DatabaseProvider.php #1451

merged 4 commits into from
Apr 18, 2020

Conversation

simonhochrein
Copy link
Contributor

Fix
[notice] E_USER_NOTICE: SQLite does not allow the charset to be changed in the DSN. in /home/user/.config/composer/vendor/phalcon/devtools/src/Providers/DatabaseProvider.php on line 69

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
This fixes an error that shows in the log when attempting to use Sqlite as the adapter in config.php.

[notice] E_USER_NOTICE: SQLite does not allow the charset to be changed in the DSN. in /home/user/.config/composer/vendor/phalcon/devtools/src/Providers/DatabaseProvider.php on line 69

I tested this on the computer that was having the problem and the error no longer occurs.

Thanks

Jeckerson and others added 4 commits December 21, 2019 21:28
Fix 
```[notice] E_USER_NOTICE: SQLite does not allow the charset to be changed in the DSN. in /home/user/.config/composer/vendor/phalcon/devtools/src/Providers/DatabaseProvider.php on line 69```
Copy link
Contributor

@jenovateurs jenovateurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeckerson
Copy link
Member

@simonhochrein Please change destination branch to 4.0.x.

@simonhochrein simonhochrein changed the base branch from master to 4.0.x April 18, 2020 11:38
@simonhochrein
Copy link
Contributor Author

Done.

@Jeckerson Jeckerson merged commit eb7f281 into phalcon:4.0.x Apr 18, 2020
@Jeckerson Jeckerson mentioned this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants