Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .phar build #1456

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Fix .phar build #1456

merged 2 commits into from
Apr 25, 2020

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Apr 25, 2020

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the [Contributing Guidelines][:contrib:]
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Composer dependencies are not discovered if directories or files are specified.
Resolution found here: box-project/box#457

@Jeckerson Jeckerson added this to the 4.0.x milestone Apr 25, 2020
@Jeckerson Jeckerson self-assigned this Apr 25, 2020
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #1456 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           4.0.x   #1456   +/-   ##
=====================================
  Coverage   3.30%   3.30%           
=====================================
  Files        111     111           
  Lines       5114    5114           
=====================================
  Hits         169     169           
  Misses      4945    4945           

@Jeckerson Jeckerson merged commit f0dbacc into 4.0.x Apr 25, 2020
@Jeckerson Jeckerson deleted the fix-phar-build branch April 25, 2020 22:56
This was referenced Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants