Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1479 more verbose pdo driver missing errors for 4.1.x #1511

Merged

Conversation

Ultimater
Copy link
Member

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

If using a PDO driver such as Postgresql or Mysql, and it is not loaded when trying to go through the Phalcon adapter, PDO will error with the vague "could not find driver" which will leave developers on a quest to figure out what happened.
This PR will fix the vague issue for 4.1.x and it will instead show a much more detailed error.

Thanks

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1511 (90db673) into 4.1.x (3df8268) will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           4.1.x   #1511      +/-   ##
========================================
+ Coverage   3.15%   3.27%   +0.12%     
========================================
  Files        111     112       +1     
  Lines       5101    5122      +21     
========================================
+ Hits         161     168       +7     
- Misses      4940    4954      +14     

@Ultimater Ultimater merged commit 5cf8c9a into phalcon:4.1.x Jul 7, 2021
@Ultimater Ultimater deleted the fix-1479-pdo-adapter-error-4.1.x branch July 7, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant