Skip to content

Commit

Permalink
Exports MinDelay and MaxDelay
Browse files Browse the repository at this point in the history
The header cannot be used outside of this package currently.
  • Loading branch information
kevmo314 committed Aug 11, 2022
1 parent 0bd9553 commit dd68857
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions playoutdelayextension.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,19 @@ var errPlayoutDelayInvalidValue = errors.New("invalid playout delay value")
// | ID | len=2 | MIN delay | MAX delay |
// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
type PlayoutDelayExtension struct {
minDelay, maxDelay uint16
MinDelay, MaxDelay uint16
}

// Marshal serializes the members to buffer
func (p PlayoutDelayExtension) Marshal() ([]byte, error) {
if p.minDelay > playoutDelayMaxValue || p.maxDelay > playoutDelayMaxValue {
if p.MinDelay > playoutDelayMaxValue || p.MaxDelay > playoutDelayMaxValue {
return nil, errPlayoutDelayInvalidValue
}

return []byte{
byte(p.minDelay >> 4),
byte(p.minDelay<<4) | byte(p.maxDelay>>8),
byte(p.maxDelay),
byte(p.MinDelay >> 4),
byte(p.MinDelay<<4) | byte(p.MaxDelay>>8),
byte(p.MaxDelay),
}, nil
}

Expand All @@ -41,7 +41,7 @@ func (p *PlayoutDelayExtension) Unmarshal(rawData []byte) error {
if len(rawData) < playoutDelayExtensionSize {
return errTooSmall
}
p.minDelay = binary.BigEndian.Uint16(rawData[0:2]) >> 4
p.maxDelay = binary.BigEndian.Uint16(rawData[1:3]) & 0x0FFF
p.MinDelay = binary.BigEndian.Uint16(rawData[0:2]) >> 4
p.MaxDelay = binary.BigEndian.Uint16(rawData[1:3]) & 0x0FFF
return nil
}
6 changes: 3 additions & 3 deletions playoutdelayextension_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestPlayoutDelayExtensionTooSmall(t *testing.T) {
}

func TestPlayoutDelayExtensionTooLarge(t *testing.T) {
t1 := PlayoutDelayExtension{minDelay: 1 << 12, maxDelay: 1 << 12}
t1 := PlayoutDelayExtension{MinDelay: 1 << 12, MaxDelay: 1 << 12}

if _, err := t1.Marshal(); !errors.Is(err, errPlayoutDelayInvalidValue) {
t.Fatal("err != errPlayoutDelayInvalidValue")
Expand All @@ -36,7 +36,7 @@ func TestPlayoutDelayExtension(t *testing.T) {
}

t2 := PlayoutDelayExtension{
minDelay: 1 << 4, maxDelay: 1 << 8,
MinDelay: 1 << 4, MaxDelay: 1 << 8,
}

if t1 != t2 {
Expand All @@ -61,7 +61,7 @@ func TestPlayoutDelayExtensionExtraBytes(t *testing.T) {
}

t2 := PlayoutDelayExtension{
minDelay: 1 << 4, maxDelay: 1 << 8,
MinDelay: 1 << 4, MaxDelay: 1 << 8,
}

if t1 != t2 {
Expand Down

0 comments on commit dd68857

Please sign in to comment.