-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the content for the Diazo theming part #1870
base: classic-ui-theming-reorg-1645
Are you sure you want to change the base?
Conversation
* Fix broken references - `link.svg` - `_inc/_install-browser-reqs-volto.md` * Fix linkcheck to bobtemplates * Update tip submodules/volto * Fix link
* Fix broken references - `link.svg` - `_inc/_install-browser-reqs-volto.md` * Fix linkcheck to bobtemplates * Update tip submodules/volto * Fix link
133787b
to
676f204
Compare
- Add note update getting help for choosing a theming method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restructured the Diazo doc to present the critical path first, followed by advice. It flows a little better, but there are still some issues with it, namely a first-timer would have no clue what to do after reading this.
|
||
## Create an add-on package | ||
|
||
To create a Diazo theme, you need to create an add-on package with [`plonecli`](https://github.com/plone/plonecli). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the pre-requisites to running plonecli
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworded this stating that you don't need to install plonecli, and you can run it using pipx, like we run cookieplone: (pipx run plonecli)
## How to theme using Diazo | ||
|
||
You can start with the provided {file}`rules.xml` file. | ||
You will need to write your own rules to bring the dynamic content from Plone into the theme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will I write any rules, when there is no reference documentation linked here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference of writing those rules is at https://docs.diazo.org/en/latest/basic.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a link to Diazo docs.
For instance, you may need to put together the main menu, the language change, and the search box. | ||
Sometimes it is easier to override the corresponding template in Plone, build the new HTML structure there, and replace one thing in the {file}`rules.xml` file than trying to write complex Diazo rules or writing XSLT. | ||
|
||
The size of the {file}`rules.xml` file and the number of rules it contains can negatively impact the performance of your site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't be a problem, since there is no reference to how to write these rules. 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above 😉
explain the purpose of each file created when addin a theme
Link to Diazo docs.
Can be seen as part of #1645
📚 Documentation preview 📚: https://plone6--1870.org.readthedocs.build/