fix(tabs): resolve ghost tab selection when collection changes (#17049) #17365
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@ANANTH4004 is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
mertsincan
added
the
Status: Pending Review
DaSchTour
reviewed
Jan 30, 2025
| @@ -89,10 +90,15 @@ export class TabList extends BaseComponent implements AfterViewInit, AfterConten | |||
|
|
|||
| scrollable = computed(() => this.pcTabs.scrollable()); | |||
|
|
|||
| @ContentChildren(Tab, { descendants: true }) tab: QueryList<Tab>; | |||
There was a problem hiding this comment.
Wouldn't it be better to use the new contentChildren Signal. I think the tabCount then could simply be a computed signal.
…ix-tabs-v18-ghost-tab-selection-17049
|
Deployment failed with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tabs): resolve ghost tab selection when collection changes (#17049)
Fixes an issue where the tab ink bar remains visible for a previously selected tab even after the underlying tab collection changes.
ContentChildrenquery tracks changes to thep-tabcomponents.Closes #17049.