Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby sass compiler warnings for unquoted color names #783

Closed
gladwearefriends opened this issue May 3, 2019 · 1 comment
Closed

Ruby sass compiler warnings for unquoted color names #783

gladwearefriends opened this issue May 3, 2019 · 1 comment

Comments

@gladwearefriends
Copy link
Contributor

Describe the bug
While upgrading to latest primer in github/resources (jekyll site) i got a lot of warnings in my terminal all along the lines of...

WARNING on line 40, column 12 of /Users/gladwearefriends/github/resources/_sass/@primer/css/utilities/colors.scss:
You probably don't mean to use the color value `pink' in interpolation here.
It may end up represented as #ffc0cb, which will likely produce invalid CSS.
Always quote color names when using them as strings (for example, "pink").
If you really want to use the color value here, use `"" + $hue'.
WARNING on line 40, column 12 of /Users/gladwearefriends/github/resources/_sass/@primer/css/utilities/colors.scss:
You probably don't mean to use the color value `purple' in interpolation here.
It may end up represented as #800080, which will likely produce invalid CSS.
Always quote color names when using them as strings (for example, "purple").
If you really want to use the color value here, use `"" + $hue'.

@shawnbot offered a fix to put the color names into quotes here: https://github.com/primer/css/blob/master/src/support/variables/color-system.scss#L235-L242

and that solved my issues! ✨

for reference: twbs/bootstrap-rubygem#130 (comment)

@primer/design-systems

@shawnbot
Copy link
Contributor

This was fixed in #794. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants