You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
While upgrading to latest primer in github/resources (jekyll site) i got a lot of warnings in my terminal all along the lines of...
WARNING on line 40, column 12 of /Users/gladwearefriends/github/resources/_sass/@primer/css/utilities/colors.scss:
You probably don't mean to use the color value `pink' in interpolation here.
It may end up represented as #ffc0cb, which will likely produce invalid CSS.
Always quote color names when using them as strings (for example, "pink").
If you really want to use the color value here, use `"" + $hue'.
WARNING on line 40, column 12 of /Users/gladwearefriends/github/resources/_sass/@primer/css/utilities/colors.scss:
You probably don't mean to use the color value `purple' in interpolation here.
It may end up represented as #800080, which will likely produce invalid CSS.
Always quote color names when using them as strings (for example, "purple").
If you really want to use the color value here, use `"" + $hue'.
Describe the bug
While upgrading to latest primer in
github/resources
(jekyll site) i got a lot of warnings in my terminal all along the lines of...@shawnbot offered a fix to put the color names into quotes here: https://github.com/primer/css/blob/master/src/support/variables/color-system.scss#L235-L242
and that solved my issues! ✨
for reference: twbs/bootstrap-rubygem#130 (comment)
@primer/design-systems
The text was updated successfully, but these errors were encountered: