-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dividers and allow sidebar positioning when Layout
is flowing as row.
#1422
Conversation
🦋 Changeset detectedLatest commit: 3955254 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Not part of this PR, but I was wondering if we should use something other than border
to show the containers, just in case someone thinks that's part of the component?
agree 100%! we can refactor the docs later :) |
Dividers
Dividers in the
Layout
component weren't correctly set when the layout was flowing as a row. Here, I extracted theflow-as-row
logic to a mixing, making it also adjust the necessary gutters and sizes for dividers. I'm also adding theLayout-divider--flowRow-shallow
andLayout-divider--flowRow-hidden
classes that were missing.Sidebar positioning
This PR also adds the
Layout--sidebarPosition-flowRow-XYZ
classes, which allows the user to decide where the sidebar should be placed when the Layout is flowing as row.cc @vdepizzol