feat: add Dolphin Release Channels #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
changed the title
NikhilNarayana
force-pushed
the
feat/beta-dolphin
branch
from
9d0f324 to
0f211e9
Compare
NikhilNarayana
force-pushed
the
feat/beta-dolphin
branch
from
c8c46c1 to
3381ca9
Compare
NikhilNarayana
force-pushed
the
feat/beta-dolphin
branch
3 times, most recently
from
d275baf to
901ad4b
Compare
NikhilNarayana
force-pushed
the
feat/beta-dolphin
branch
2 times, most recently
from
f6165c0 to
aca6dd5
Compare
and reword everything to be {netplay,playback}Beta(Dolphin) and dolphinBeta
this also removes the dolphin path settings
NikhilNarayana
force-pushed
the
feat/beta-dolphin
branch
from
6e69004 to
609bd7f
Compare
vinceau
approved these changes
Oct 16, 2023
| import { downloadLatestDolphin } from "./download"; | ||
| import type { DolphinVersionResponse } from "./fetchLatestVersion"; | ||
|
|
||
| const log = electronLog.scope("dolphin/installation"); |
There was a problem hiding this comment.
Suggested change
| const log = electronLog.scope("dolphin/installation"); | |
| const log = electronLog.scope("dolphin/mainlineInstallation"); |
Do you think this would be helpful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
This PR builds out functionality to support installations of dolphin betas that live side by side with the stable version. This is to ensure users can swap between the two at will as well as allow us to automatically swap back to stable if beta dolphin is lagging behind release-wise.
How
This PR makes
DolphinInstallationan interface that gets implemented byIshiirukaDolphinInstallationandMainlineDolphinInstallation. There are a limited number of changes made to Ishiiruka's installation method such as the installation folder no longer being a setting that is passed in andfetchLatestVersionbeing called from the Dolphin manager side.Order of operations for installing/updating dolphin
Current
DolphinManagercallsthis.getInstallation()and theninstallation.validate()orinstallation.downloadAndInstall().fetchLatestVersion()gets called from within the functions above and accepts theDolphinLaunchType. it will only ever return the current stable release since the beta flag is hard coded to false.New
DolphinManagercallsfetchLatestVersion()before callingthis.getInstallation()fetchLatestVersion()accepts theDolphinLaunchType,includeBetaflag, and a reference tosettingsManager. it will pass the beta flag into the gql request to get either the stable release or latest release.fetchLatestVersion()will check the version returned by the backend for-beta, then it will callsettingsManager.setDolphinBetaAvailable()to allow the rest of the app to know if it should use beta DolphinfetchLatestVersion()returnsDolphinVersionResponse.this.getInstallation()is called and will returnMainlineDolphinInstallationif a beta is available orpromoteToStableis true andIshiirukaDolphinInstallationotherwise.currently this is for netplay only because mainline playback still has a lot of work to be done