Added media queries for 2.5K and 4K screens #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redonkulus Is there any plan for merging this? We want to be able to use it on prod. |
redonkulus
approved these changes
Oct 19, 2022
|
Now released in [email protected] |
|
-xxxl could be -x2k for short. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a page with a grid of cards, if the layout takes up the full width of the screen, there are significant differences between FHD, QHD, and 4K screens. What looks good on a FHD screen, can look either sparse or stretched out on a QHD/4K screen.
So I extended it to include 2.5K (
xxxl) and 4K (x4k) media queries.I use it from the local directory but it'd be better to have it over the CDN, so others can use it also.