Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Include CHANGELOG.md and LICENSE in tool.flit.sdist #3101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Feb 1, 2025

No description provided.

@stefan6419846
Copy link
Collaborator

Could you please elaborate on this as requested in one of your previous PRs? Especially since it already works correctly:

Bildschirmfoto_20250201_151901

@j-t-1
Copy link
Contributor Author

j-t-1 commented Feb 1, 2025

Can ".flake8", ".pylintrc" and "tox.ini" be removed from the exclude array of tool.flit.sdist?

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (67e1781) to head (69fc476).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3101   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          52       52           
  Lines        8811     8811           
  Branches     1614     1614           
=======================================
  Hits         8501     8501           
  Misses        185      185           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Feb 1, 2025

Could you please elaborate on this as requested in one of your previous PRs? Especially since it already works correctly:

This is trying to remove the need for MANIFEST.in. I do not fully understand the build process so this PR may need further scrutiny.

@stefan6419846
Copy link
Collaborator

I recommend extending the existing CI workflows to check for some of the expected files in both distributions in the package step and remove the MANIFEST file if everything is working correctly.

@stefan6419846 stefan6419846 added the needs-change The PR/issue cannot be handled as issue and needs to be improved label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-change The PR/issue cannot be handled as issue and needs to be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants