PyInstaller: Complete types in build_main.pyi #13528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete the incomplete types of Analysis class constructor params.
This comment has been minimized.
This comment has been minimized.
sobolevn
requested changes
Feb 23, 2025
Add annotations for instance attributes.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
reviewed
Feb 24, 2025
| hookspath: list[tuple[StrPath, int]] | ||
| excludes: list[str] | ||
| custom_runtime_hooks: list[StrPath] | ||
| module_collection_mode: dict[str, Literal["pyz", "pyc", "py", "pyz+py", "py+pyz"]] |
There was a problem hiding this comment.
I would prefer to have this as
Suggested change
| module_collection_mode: dict[str, Literal["pyz", "pyc", "py", "pyz+py", "py+pyz"]] | |
| module_collection_mode: dict[str, str] |
Literal types are hard :)
| cipher: _PyiBlockCipher = None, | ||
| win_no_prefer_redirects: bool = False, | ||
| win_private_assemblies: bool = False, | ||
| noarchive: bool = False, | ||
| module_collection_mode: Incomplete | None = None, | ||
| # https://pyinstaller.org/en/stable/hooks.html#hook-global-variables | ||
| module_collection_mode: dict[str, Literal["pyz", "pyc", "py", "pyz+py", "py+pyz"]] | None = None, |
There was a problem hiding this comment.
Here we need to use dict[str, str], because it is hard to infer dict[str, Literal] type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the incomplete types of Analysis class constructor params.