Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the concurrent request. #38

Closed
wants to merge 2 commits into from
Closed

Support the concurrent request. #38

wants to merge 2 commits into from

Conversation

lsk569937453
Copy link

  1. Add the concurrency examples for pure Grpc client and Qdrant client.
  2. Remove the Rwlock of Channel as the concurrency request could use the same channel.
  3. Remove the allow_retry param for with_channel as the tonic will retry automatically.

@lsk569937453 lsk569937453 marked this pull request as draft May 3, 2023 00:19
@lsk569937453 lsk569937453 marked this pull request as ready for review May 3, 2023 00:19
@agourlay
Copy link
Member

agourlay commented May 3, 2023

Thanks for your contribution!

Could you please elaborate regarding the motivation for this change?

Also it would be easier to review if the clippy fixes were handled in a different PR.

@lsk569937453
Copy link
Author

lsk569937453 commented May 3, 2023

Hello, I want to join the company of Qdrant. I have sent the cv. And Andre said that I have to make a contribution to the https://github.com/qdrant/rust-client. And I get this issue(#30) in the github issues.
For the concurrent use of the client, I get hyperium/tonic#285 maybe we do not need the pool to do the concurrent request. We could just clone the client to do the concurrent request.
I don't understand which style we use.I just format it using rust-clippy.

@lsk569937453 lsk569937453 closed this by deleting the head repository Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants