Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oldIE bug where window.location is undefined due to a UMD scoping issue #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix oldIE bug where window.location is undefined due to a UMD scoping issue #76

wants to merge 1 commit into from
+12 −11

Conversation

nason
Copy link
Contributor

@nason nason commented Nov 9, 2016

I was getting consistent errors in IE10 and below with this lib @ 56addf6

"Unable to get property 'protocol' of undefined or null reference"

I believe this is due to the way I was bundling this package (via rollup, and sometimes webpack)

@StephenHynes7
Copy link
Contributor

Does document.location work instead? Not a massive fan of using location as it's easier for it get overwritten accidentally.

@nason
Copy link
Contributor Author

nason commented Nov 10, 2016

Thats a good point :) I just noticed #30 as well, which is probably the more correct fix.

FYI I have a WIP branch that gets the tests running again. Perhaps that + #30 is a better way to solve this issue

@nason nason mentioned this pull request Nov 10, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nason @StephenHynes7