-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): fixed color contrast and heading issues #7424
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ function NavItem({url, isActive, children}: any) { | |
'active:scale-95 transition-transform w-full text-center outline-link py-1.5 px-1.5 xs:px-3 sm:px-4 rounded-full capitalize whitespace-nowrap', | ||
!isActive && 'hover:bg-primary/5 hover:dark:bg-primary-dark/5', | ||
isActive && | ||
'bg-highlight dark:bg-highlight-dark text-link dark:text-link-dark' | ||
'bg-highlight dark:bg-highlight-dark text-link-10 dark:text-link-dark' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think |
||
)}> | ||
{children} | ||
</Link> | ||
|
@@ -304,7 +304,7 @@ export default function TopNav({ | |
<button | ||
type="button" | ||
className={cn( | ||
'flex 3xl:w-[56rem] 3xl:mx-0 relative ps-4 pe-1 py-1 h-10 bg-gray-30/20 dark:bg-gray-40/20 outline-none focus:outline-link betterhover:hover:bg-opacity-80 pointer items-center text-start w-full text-gray-30 rounded-full align-middle text-base' | ||
'flex 3xl:w-[56rem] 3xl:mx-0 relative ps-4 pe-1 py-1 h-10 bg-gray-30/20 dark:bg-gray-40/20 outline-none focus:outline-link betterhover:hover:bg-opacity-80 pointer items-center text-start w-full rounded-full align-middle text-base' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe |
||
)} | ||
onClick={onOpenSearch}> | ||
<IconSearch className="align-middle me-3 text-gray-30 shrink-0 group-betterhover:hover:text-gray-70" /> | ||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -18,7 +18,7 @@ function InlineCode({ | |||||||||
className={cn( | ||||||||||
'inline text-code text-secondary dark:text-secondary-dark px-1 rounded-md no-underline', | ||||||||||
{ | ||||||||||
'bg-gray-30 bg-opacity-10 py-px': !isLink, | ||||||||||
'bg-opacity-10 py-px': !isLink, | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of removing the background, can you update the react.dev/src/styles/index.css Lines 447 to 450 in af0358f
|
||||||||||
'bg-highlight dark:bg-highlight-dark py-0': isLink, | ||||||||||
} | ||||||||||
)} | ||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -263,7 +263,7 @@ export default function ShoppingList() { | |
<li | ||
key={product.id} | ||
style={{ | ||
color: product.isFruit ? 'magenta' : 'darkgreen' | ||
color: product.isFruit ? 'darkblue' : 'darkgreen' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}} | ||
> | ||
{product.title} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using
text-primary
can we addtest-link-secondary
with value#045975
(blue-60). This will keep the vibe, while maintaining a good contrast ratio.