Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature deleting images #1861

Closed
MauriceVanLier opened this issue Aug 6, 2012 · 6 comments · Fixed by #2101
Closed

Feature deleting images #1861

MauriceVanLier opened this issue Aug 6, 2012 · 6 comments · Fixed by #2101

Comments

@MauriceVanLier
Copy link

When i'm on page 3 of my images for example, and i delete one, i land on page 1. So i first must go back page 3 to delete more images of the same project for example. I would be nice if i could stay on the same page to delete more images.

@ugisozols
Copy link
Member

👍 for this!

@ghost ghost assigned ugisozols Aug 6, 2012
@parndt
Copy link
Member

parndt commented Aug 10, 2012

I believe this is because crudify doesn't respect paging when destroying:

https://github.com/resolve/refinerycms/blob/master/core/lib/refinery/crud.rb#L148-L156

@gwagener
Copy link
Contributor

This is definitely doable, you just have to watch out for the edge case of deleting the last image on a page.

@parndt
Copy link
Member

parndt commented Dec 21, 2012

@gwagener what would happen if you did?

@ugisozols
Copy link
Member

It should be smart enough to redirect to previous (if it exists) or stay on the first (if it's the only one) page.

@parndt
Copy link
Member

parndt commented Dec 29, 2012

I've opened a pull request #2101 which implements this feature for 2.1.0 :) thanks.

@parndt parndt closed this as completed in adc7e47 Jan 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants