Gave crud the notion of redirect paging. #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also includes a hefty crud refactor. |
| @@ -184,6 +145,15 @@ def paginate_all_#{plural_name} | |||
| @#{plural_name} = @#{plural_name}.paginate(:page => params[:page], :per_page => per_page) | |||
| end | |||
|
|
|||
| def redirect_url | |||
| if (page = params[:page]).present? && (page = page.to_i rescue 1) | |||
There was a problem hiding this comment.
What's the point of having the to_i rescue 1 in the conditional? Won't that always return truthy?
There was a problem hiding this comment.
To make page 1 the default page
There was a problem hiding this comment.
Yes, but since the default is truthy it's an irrelevant part of an &&. You could instead write:
if params[:page].present?
page = params[:page].to_i rescue 1
page -= ...This would lead to a much less confusing conditional since there's no need to set the page variable in it.
ugisozols
added a commit
that referenced
this pull request
Jan 7, 2013
Gave crud the notion of redirect paging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1861