Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least Ruby 1.9.3 and thus drop Ruby 1.8.x support. #2277

Merged
merged 2 commits into from
May 29, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,5 @@ matrix:
rvm:
- 2.0.0
- 1.9.3
- 1.8.7
- rbx-19mode
- jruby-19mode
- rbx-18mode
- jruby-18mode
5 changes: 1 addition & 4 deletions core/lib/refinery/crud.rb
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,7 @@ def reorder
def update_positions
previous = nil
params[:ul].each do |_, list|
# After we drop Ruby 1.8.x support the following line can be changed back to
# list.each do |index, hash|
# because there won't be an ordering issue (see https://github.com/refinery/refinerycms/issues/1585)
list.sort_by {|k, v| k.to_i}.map { |item| item[1] }.each_with_index do |hash, index|
list.each do |index, hash|
moved_item_id = hash['id'].split(/#{singular_name}\_?/).reject(&:empty?).first
@current_#{singular_name} = #{class_name}.find_by_id(moved_item_id)

Expand Down
4 changes: 3 additions & 1 deletion core/refinerycms-core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ Gem::Specification.new do |s|
s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- spec/*`.split("\n")

s.required_ruby_version = '>= 1.9.3'

s.add_dependency 'refinerycms-i18n', '~> 2.1.0.dev'
s.add_dependency 'awesome_nested_set', '~> 2.1.3'
s.add_dependency 'railties', rails_version
s.add_dependency 'activerecord', rails_version
s.add_dependency 'actionpack', rails_version
s.add_dependency 'truncate_html', '~> 0.5.5'
s.add_dependency 'truncate_html', '~> 0.9'
s.add_dependency 'will_paginate', '~> 3.0.2'
s.add_dependency 'sass-rails', '~> 3.2.3'
s.add_dependency 'jquery-rails', ['>= 2.0.0', '< 2.3.0']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ h3. Checklist

If you are already a Rails developer, you will most likely not have to install anything else. Here's the requirements for Refinery:

* *Ruby* - 1.8.7, 1.9.2, 1.9.3, Rubinius, and JRuby are all acceptable
* *Ruby* - 1.9.3, 2.0.0, Rubinius, and JRuby are all acceptable
* *RubyGems* - Recommended that you have the latest version installed
* *Database* - SQLite3 (default), MySQL, or PostgreSQL
* *ImageMagick* - Recommended that you have the latest version installed
Expand Down Expand Up @@ -57,8 +57,6 @@ h4. Ruby

TIP. The best way to install Ruby is using the "Ruby Version Manager":https://rvm.beginrescueend.com/ (RVM)

Ruby 1.8.7 comes installed by default on a mac. Lucky you!

h4. Rubygems

Rubygems also comes installed by default, however, it is an old version which will cause problems. Update using:
Expand Down
2 changes: 1 addition & 1 deletion doc/guides/1 - Getting Started/2 - Getting Started.textile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ h3. Guide Assumptions

This guide is designed for beginners who want to get started with a Refinery CMS site from scratch. It does not assume that you have any prior experience with Refinery. However, to get the most out of it, you need to have some prerequisites installed:

* The "Ruby":http://www.ruby-lang.org/en/downloads language version 1.8.7 or higher (1.9.3 recommended)
* The "Ruby":http://www.ruby-lang.org/en/downloads language version 1.9.3 or higher

TIP: Do not use Ruby 1.9.1 as Rails 3.x is not compatible with it. Use 1.9.3 for smooth sailing.

Expand Down