Add preview skip_to_first_child page message #3168
Conversation
| @@ -40,6 +40,8 @@ en: | |||
| view_live_html: View this page live <br/><em>(opens in a new window)</em> | |||
| hidden: hidden | |||
| draft: draft | |||
| preview: | |||
| skip_to_first_child: "The page %{what} use the option \"Skip to first child\" and will never be displayed to guest users." | |||
There was a problem hiding this comment.
uses not use here
guest users should be visitors
There was a problem hiding this comment.
Fixed and will be push.
bricesanchez
changed the title
|
Ready to be reviewed (with tests) |
|
Thanks! I know this might be annoying, but can you add a test (here: https://github.com/refinery/refinerycms/blob/master/pages/spec/features/refinery/pages_spec.rb#L320-L338) for when you visit the page normally (as a visitor) to make sure that we don't see the message (i.e. that the page that's redirected to doesn't somehow display it?) Mainly to protect against regressions. |
|
No problem, it's done. |
|
I don't understand, none of my tests fails on local, is there a problem with the Travis config ? |
|
Very rarely is Travis the problem.. I'll look at it in a few hours |
bricesanchez
force-pushed
the
feature/2707
branch
2 times, most recently
from
85f9258 to
885057b
Compare
* Remove layout def, we use render_with_templates? method * Improve page_params (:custom_slug was missing)
|
The problem was Bundler versions 1.12.0 through 1.12.3. Fixed in 1.12.4 |
|
Thanks @parndt for finding the solution! |
No description provided.