enable reselection of resource after removal #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,9 @@ | |||
| <%= f.hidden_field field %> | |||
|
|
|||
| <div> | |||
| <%= action_icon :add, insert_link, t('.name'), id: "current_resource_link_#{field}" unless resource %> | |||
| <div id="no_resource_selected_<%= field %>", style="<%= 'display: none' if resource %>"> | |||
There was a problem hiding this comment.
i will prefer the use of content_tag view helper, it's easier to read :
<%= content_tag(:div, id: "no_resource_selected_#{field}", style: "display: none;" if resource) do %>
<%= action_icon :add, insert_link, t('.name'), id: "current_resource_link_#{field}" %>
<% end %>
|
Thanks for your contribution, could you make this changes after @parndt review? |
|
Can you show us a before/after screenshot of what this is expected to change please? |
|
The current flow is that we start from the following: From here, we click the remove button on the right side. Without this change, there's nothing there: With this change, the add button re-appears: |
|
Perfect, I can confirm the solution, thanks! |
bricesanchez
pushed a commit
that referenced
this pull request
Jul 19, 2016
* enable reselection of resource after removal * use content_tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with the resource picker not allowing selection of a new resource after removing an already existing resource.