Remove deprecated heroku gem

[bricesanchez]

Fetching: heroku-3.43.12.gem (100%)
 !    The `heroku` gem has been deprecated and replaced with the Heroku Toolbelt.
 !    Download and install from: https://toolbelt.heroku.com
 !    For API access, see: https://github.com/heroku/heroku.rb

[parndt]

We need this to be present, it's used in the generator, and I'm pretty sure it's had that deprecation message for a long time now.

[bricesanchez]

It's provide by the toolbelt now and our guide explicit that we need to have the toolbelt.

[parndt]

My major complaint is that if people specify --heroku it won't automatically set things up, it'll fail. Maybe we should abort if the Heroku command isn't available?

[bricesanchez]

I've tried something, let me know if it's ok for you

[bricesanchez]

friendly ping @parndt

[parndt]

heroku -v doesn't work for me, but heroku --version does.

How about:

unless system("heroku --version")
  fail <<-ERROR
\033[31m[ABORTING]\033[0m Heroku Toolbelt is not installed. Please re-start the installer after installing at:\nhttps://devcenter.heroku.com/articles/heroku-command-line
ERROR
end

And can we put the check inside a method like heroku_toolbelt_missing?

def heroku_toolbelt_missing?
  !!system("heroku --version")
end

Then:

if heroku_toolbelt_missing?
  fail <<-ERROR
\033[31m[ABORTING]\033[0m Heroku Toolbelt is not installed. Please re-start the installer after installing at:\nhttps://devcenter.heroku.com/articles/heroku-command-line
ERROR
end

[bricesanchez]

🆙 😄

[parndt]

Thanks!