[REF-2306] Include twine in dependencies on pyproject.toml #2895
+269
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
approved these changes
Mar 21, 2024
masenf
reviewed
Mar 21, 2024
| try: | ||
| import twine # noqa: F401 # type: ignore | ||
| except (ImportError, ModuleNotFoundError) as ex: | ||
| if not _pip_install_on_demand("twine"): |
There was a problem hiding this comment.
why not "twine>=4.0.0" here?
There was a problem hiding this comment.
If a twine below 4.0.0 is already installed we won't enter the except
There was a problem hiding this comment.
I think we kinda touched on this in the standup. I feel the main reason we wanted to do like this is for the installed payload from reflex. Twine is not a big package (not sure how to measure it), but the files in the site-packages directory seem to only mount to around a couple 100KBs. That's not a good enough reason to dance around an already established mechanism of specifying dependencies. Please feel free to share more thoughts. I guess some of the earlier messages likely preceded our standup discussion.
masenf
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.