components as literal vars #4223
Conversation
| return Bare.create("") | ||
|
|
||
|
|
||
| def render_dict_to_var(tag: dict | Component | str, imported_names: set[str]) -> Var: |
There was a problem hiding this comment.
it would be nice if we could move some of this special specific logic closer to the components that will actually depend on it
There was a problem hiding this comment.
at the current stage there's no standardization of the dict format, so the checks are very tight to what we have right now, i can restructure the rendering logic in the future if needed
|
should be merged with reflex-dev/reflex-web#1047 |
|
waiting on reflex-dev/reflex-web#1050 |
adhami3310
changed the title
adhami3310
changed the title
done |
There was a problem hiding this comment.
Why are those tests removed? Is there a replacement that cover same usecases?
There was a problem hiding this comment.
they are removed because it's annoyingly specific, since there are integration test cases I thought it's not worth the effort of having test cases that just repeat the logic of the code.
No description provided.