Reuse the sqlalchemy engine once it's created #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires setting `async_db_url` to the same database as `db_url`, except using an async driver; this will vary by database.
Lendemor
previously approved these changes
Dec 6, 2024
Move connect engine kwargs to a separate function
|
latest commit unifies the connection args and adds |
throw a warning if the part following the `://` differs between these two
update types
reflex/config.py
Outdated
| @@ -568,6 +571,10 @@ class EnvironmentVariables: | |||
| environment = EnvironmentVariables() | |||
|
|
|||
|
|
|||
| # These vars are not logged because they may contain sensitive information. | |||
| _sensitive_env_vars = {"DB_URL", "ASYNC_DB_URL"} | |||
There was a problem hiding this comment.
maybe we should add redis url here as well?
Lendemor
requested changes
Dec 9, 2024
Lendemor
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.