Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests follow up #657

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Integration tests follow up #657

merged 1 commit into from
Mar 11, 2023

Conversation

ElijahAhianyo
Copy link
Contributor

@ElijahAhianyo ElijahAhianyo commented Mar 10, 2023 •
edited
Loading

this PR improves the integration tests to test pcweb codebase and the counter example

fixes #658

@ElijahAhianyo ElijahAhianyo force-pushed the feature/integration-tests-improvements branch from 8d7b257 to 662f393 Compare March 10, 2023 11:08
@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review March 10, 2023 11:10
picklelo
picklelo approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@picklelo
Copy link
Contributor

We have some updates to pcweb we need to merge to get these integration tests passing - will do that today.

@picklelo picklelo merged commit 38ecc66 into reflex-dev:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests follow up
2 participants
@ElijahAhianyo @picklelo