Add FeatureBuilder.fromSchema #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @takezoe to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 86.51% 86.49% -0.02%
==========================================
Files 329 329
Lines 10598 10599 +1
Branches 336 548 +212
==========================================
- Hits 9169 9168 -1
- Misses 1429 1431 +2
Continue to review full report at Codecov.
|
tovbinm
reviewed
May 26, 2019
| @@ -215,6 +216,7 @@ object FeatureBuilder { | |||
| } | |||
| responseFeature -> features | |||
| } | |||
| def fromDataFrame[ResponseType <: FeatureType : WeakTypeTag](data: DataFrame, response: String, nonNullable: Set[String] = Set.empty): (Feature[ResponseType], Array[Feature[_ <: FeatureType]]) = fromSchema(data.schema, response, nonNullable) | |||
takezoe
force-pushed
the
features-from-schema
branch
from
865ddca to
f077ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the proposed solution
This pull request adds
FeatureBuilder.fromSchemathat allows to create features from schema.Describe alternatives you've considered
FeatureBuilderalready has a method to create features fromDataFrame, but actually, only schema is necessary to create features.