Remove fake su used in integration tests #48796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
changed the title
|
okay it looks like only this test failed: The cent7 py2 test failures seem unrelated because the build failed early so i'm re-running that job right now just to make sure: https://jenkinsci.saltstack.com/job/pr-kitchen-centos7-py2/job/PR-48796/2/ |
rallytime
approved these changes
Jul 27, 2018
rallytime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I found that this
suin mockbin is causing some issues with mac tests in 2018.3 as documented in issue saltstack/salt-ci-images#1033 . I just need to see the tests run on this. I tried running some tests with kitchen locally but I believe I have some slowness network issues and it was taking more then 3 hours. Instead of running locally at this point wanted to push as a PR to see the test results. I am not necessarily proposing this change yet.What issues does this PR fix or reference?
saltstack/salt-ci-images#1033