Matthewsaum 62275

[matthewsaum]

What does this PR do?

Adds the "dig.X" function to the dig execution module. This allows the resolution of PTR records for entered IP addresses

What issues does this PR fix or reference?

Fixes:
62275

Previous Behavior

Dig module was unable to resolve PTR records

New Behavior

Dig module can now resolve PTR records

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[nicholasmhughes]

re-run pr-windows-2019-x64-py3-pytest

[nicholasmhughes]

Looks great! Just one chore to fix. This is probably too late to hit 3005, so it will make the 3006 release.

[matthewsaum]

Ok. I think I got everything right then. Thanks for helping me get this integrated. My git-workflow experience is fairly limited.

[nicholasmhughes]

re-run pr-windows-2016-x64-py3-pytest

[nicholasmhughes]

re-run pr-photon-3-x86_64-py3-pytest

[matthewsaum]

So, this is my first pull request. I'll take any and all feedback as to things I could have/should have done better here. Now that it looks like things are cleaned up and stable for the request.
And not just for Salt, but in general. My GIT working knowledge is using CI/CD to automate my sysadmin tasks. If ya'll have time to drop a few sentences, it would be awesome. And if not, thanks for helping this along anyway

[nicholasmhughes]

@matthewsaum , I think everything went pretty smoothly. The only thing I'd say is to leave the PR alone after it's approved unless there's something big that's wrong. Changing small things, like the newline addition or just merging master where there wouldn't be a conflict, isn't worth dismissing the review and triggering all of the tests again. Thanks for the effort and the contribution!

[welcome]

Congratulations on your first PR being merged! 🎉